Move all config variable usage to the property system #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
January 28, 2023 01:52
This bc-break decreases cognitive load while performing any refactor.
This aligns the plugin with how core plugin properties are managed.
This is necessary due to nginx_restart not being exposed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat major refactor - due to function moves and a few rewrites - but works as desired in my testing.
The refactor was somewhat necessary as it was actually pretty difficult to see what functions were being used where and how due to how the plugin has developed over time. It isn't complete, but its quite good as is.
See #262 for some initial inspiration.