Skip to content

Commit

Permalink
fix: update link docs to remove erroneous copy-paste
Browse files Browse the repository at this point in the history
  • Loading branch information
Jose Diaz-Gonzalez committed Feb 25, 2023
1 parent 0e04a64 commit cdbf519
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 14 deletions.
10 changes: 2 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ DOKKU_RETHINKDB_LOLLIPOP_PORT_28015_TCP_ADDR=172.17.0.1
The following will be set on the linked application by default:

```
RETHINKDB_URL=rethinkdb://lollipop:SOME_PASSWORD@dokku-rethinkdb-lollipop:28015/lollipop
RETHINKDB_URL=rethinkdb://dokku-rethinkdb-lollipop:28015/lollipop
```

The host exposed here only works internally in docker containers. If you want your container to be reachable from outside, you should use the `expose` subcommand. Another service can be linked to your app:
Expand All @@ -232,13 +232,7 @@ dokku rethinkdb:link lollipop playground
This will cause `RETHINKDB_URL` to be set as:

```
rethinkdb2://lollipop:SOME_PASSWORD@dokku-rethinkdb-lollipop:28015/lollipop
```

If you specify `RETHINKDB_DATABASE_SCHEME` to equal `http`, we`ll also automatically adjust `RETHINKDB_URL` to match the http interface:

```
http://lollipop:SOME_PASSWORD@dokku-rethinkdb-lollipop:${PLUGIN_DATASTORE_PORTS[1]}
rethinkdb2://dokku-rethinkdb-lollipop:28015/lollipop
```

### unlink the rethinkdb service from the app
Expand Down
8 changes: 2 additions & 6 deletions subcommands/link
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ service-link-cmd() {
#E
#E the following will be set on the linked application by default:
#E
#E ${PLUGIN_DEFAULT_ALIAS}_URL=${PLUGIN_SCHEME}://lollipop:SOME_PASSWORD@dokku-${PLUGIN_COMMAND_PREFIX}-lollipop:${PLUGIN_DATASTORE_PORTS[0]}/lollipop
#E ${PLUGIN_DEFAULT_ALIAS}_URL=${PLUGIN_SCHEME}://dokku-${PLUGIN_COMMAND_PREFIX}-lollipop:${PLUGIN_DATASTORE_PORTS[0]}/lollipop
#E
#E the host exposed here only works internally in docker containers.
#E if you want your container to be reachable from outside, you should
Expand All @@ -37,11 +37,7 @@ service-link-cmd() {
#E dokku $PLUGIN_COMMAND_PREFIX:link lollipop playground
#E this will cause ${PLUGIN_DEFAULT_ALIAS}_URL to be set as:
#E
#E ${PLUGIN_SCHEME}2://lollipop:SOME_PASSWORD@dokku-${PLUGIN_COMMAND_PREFIX}-lollipop:${PLUGIN_DATASTORE_PORTS[0]}/lollipop
#E
#E If you specify ${PLUGIN_VARIABLE}_DATABASE_SCHEME to equal `http`, we'll also automatically adjust ${PLUGIN_DEFAULT_ALIAS}_URL to match the http interface:
#E
#E http://lollipop:SOME_PASSWORD@dokku-${PLUGIN_COMMAND_PREFIX}-lollipop:${PLUGIN_DATASTORE_PORTS[1]}
#E ${PLUGIN_SCHEME}2://dokku-${PLUGIN_COMMAND_PREFIX}-lollipop:${PLUGIN_DATASTORE_PORTS[0]}/lollipop
#A service, service to run command against
#A app, app to run command against
#F -a|--alias "BLUE_DATABASE", an alternative alias to use for linking to an app via environment variable
Expand Down

0 comments on commit cdbf519

Please sign in to comment.