Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerequisite changes to allow Java buildpack support #1

Merged
merged 7 commits into from Jun 9, 2013

Conversation

rnorth
Copy link
Contributor

@rnorth rnorth commented Jun 9, 2013

Hi,
These commits add:

  • sourcing of /app/.profile.d scripts to allow dependencies like Java to be activated properly for the java buildpack to work
  • allowing a developer to override repository/script locations when running the bootstrap.sh script using environment variables. Your repo locations remain the defaults.

I've tested using forks of the Java and Ruby samples from Heroku (https://github.com/rnorth/java-sample and https://github.com/rnorth/ruby-sample) - the ruby sample needed some dependencies to be updated.

Hope this is OK!

Richard

…/app/.profile.d), so that dependencies downloaded by the buildpack are available on PATH.

The docker run command which starts the app is now a little verbose so maybe should be refactored into a separate script; part of the verbosity is because of guarding against absence of the .profile.d directory.

This is to support use of the Java buildpack but has also been tested working for a simple Ruby web app.
…bles for hacking; using progrium's locations as the default.
progrium added a commit that referenced this pull request Jun 9, 2013
Prerequisite changes to allow Java buildpack support
@progrium progrium merged commit 3c3a63a into dokku:master Jun 9, 2013
mincedmit pushed a commit to ginlane/dokku that referenced this pull request Feb 13, 2014
Prerequisite changes to allow Java buildpack support
josegonzalez pushed a commit that referenced this pull request Nov 24, 2014
michaelshobbs pushed a commit that referenced this pull request Apr 26, 2015
josegonzalez pushed a commit that referenced this pull request Nov 5, 2015
Only return users of group 'adm'
josegonzalez pushed a commit that referenced this pull request Mar 13, 2016
@J77J J77J mentioned this pull request Aug 23, 2017
@m7mdcc m7mdcc mentioned this pull request Apr 26, 2022
@amirarabirazdadeh amirarabirazdadeh mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants