New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerequisite changes to allow Java buildpack support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/app/.profile.d), so that dependencies downloaded by the buildpack are available on PATH. The docker run command which starts the app is now a little verbose so maybe should be refactored into a separate script; part of the verbosity is because of guarding against absence of the .profile.d directory. This is to support use of the Java buildpack but has also been tested working for a simple Ruby web app.
…bles for hacking; using progrium's locations as the default.
…in bootstrap script.
…reading for regular users.
progrium
added a commit
that referenced
this pull request
Jun 9, 2013
Prerequisite changes to allow Java buildpack support
mincedmit
pushed a commit
to ginlane/dokku
that referenced
this pull request
Feb 13, 2014
Prerequisite changes to allow Java buildpack support
This was referenced Jan 3, 2015
michaelshobbs
pushed a commit
that referenced
this pull request
Apr 26, 2015
add test for off-port git remote
josegonzalez
pushed a commit
that referenced
this pull request
Nov 5, 2015
Only return users of group 'adm'
Closed
This was referenced Jan 11, 2017
Closed
Closed
This was referenced Aug 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
These commits add:
I've tested using forks of the Java and Ruby samples from Heroku (https://github.com/rnorth/java-sample and https://github.com/rnorth/ruby-sample) - the ruby sample needed some dependencies to be updated.
Hope this is OK!
Richard