Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide admin actions for manually (un-)subscribing users #42

Merged
merged 3 commits into from
Mar 8, 2013
Merged

Provide admin actions for manually (un-)subscribing users #42

merged 3 commits into from
Mar 8, 2013

Conversation

jnns
Copy link
Contributor

@jnns jnns commented Jan 17, 2013

We had an error with our e-mail delivery and I wanted to manually select users which should be subscribed. Admin actions were missing so I added them.

@dokterbob
Copy link
Collaborator

Thanks @jnns! Code looks good.

Though one request: please use gettext _(u'blah') for the user facing strings. I like to keep django-newsletter fully translatable.

@dokterbob
Copy link
Collaborator

@jnns Hey Jannis, could you please make the strings in your patch translatable? I'd really love to merge your patch to make it available to other users of newsletter.

Thanks again!

@jnns
Copy link
Contributor Author

jnns commented Feb 27, 2013

Sorry, Mathijs, for the delay and thanks for reminding me. I added the missing calls so feel free to merge!

@dokterbob
Copy link
Collaborator

@jnns Sorry to be a bit of a pest but wouldn't it be a lot simpler if you used gettext pluralization? :)
https://docs.djangoproject.com/en/1.4/topics/i18n/translation/#pluralization

If you could make one more update (and optionally squash the commits) I'd greatly appreciate.

(Squashing/rewriting: 1. Make backup of dir. 2. git rebase -i master)

Thanks!

@jnns
Copy link
Contributor Author

jnns commented Feb 27, 2013

No worries – I'm glad to learn something new; never had to translate a project and thus didn't know about gettext pluralization. Will do a squashed commit in a few moments.

@dokterbob
Copy link
Collaborator

Op 27-02-13 14:55, Jannis schreef:

No worries – I'm glad to learn something new; never had to translate a
project and thus didn't know about gettext pluralization. Will do a
squashed commit in a few moments.
Better do a push first. I'm not 1000% sure it will work for Django 1.3
as well.

dokterbob added a commit that referenced this pull request Mar 8, 2013
Provide admin actions for manually (un-)subscribing users.
@dokterbob dokterbob merged commit e7ebff5 into jazzband:master Mar 8, 2013
@dokterbob
Copy link
Collaborator

It's merged, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants