PHP8: Avoid warnings

Warning: Trying to access array offset on value of type bool in lib/plugins/discussion/helper.php
dokufreaks · Feb 13, 2024 · b189aa8 · b189aa8
1 parent a13deda
commit b189aa8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/action.php b/action.php
@@ -953,7 +953,7 @@ protected function showReplyForm($cid, $reply)
     protected function showReplies($cid, &$data, $reply, &$isVisible)
     {
         $comment = $data['comments'][$cid];
-        if (!count($comment['replies'])) {
+        if (!empty($comment['replies'])) {
             return;
         }
         ptln('<div class="comment_replies"' . $this->getWidthStyle() . '>', 4);

diff --git a/helper.php b/helper.php
@@ -81,9 +81,13 @@ public function td($id, $col = null, &$class = null, $num = null)
             $cfile = metaFN($id, '.comments');
             $comments = unserialize(io_readFile($cfile, false));
 
-            $num = $comments['number'];
-            if (!$comments['status'] || ($comments['status'] == 2 && !$num)) {
+            if ($comments) {
+              $num = $comments['number'];
+              if (!$comments['status'] || ($comments['status'] == 2 && !$num)) {
                 return '';
+              }
+            } else {
+              $num = 0;
             }
         }