Major Refactoring, Clean-Up and Simplification #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin tried to do a lot of things and thus was hard to maintain. The documentation was severely lacking.
This is a very opinionated refactoring on the basic assumption that this plugin should only do one thing: list files that are external to the wiki and make them downloadable. Thus:
The mechanism to configure allowed paths have been completely overhauled:
W>
prefixA>
prefixWith the above you could use
{{filelist>fileserver/somedir/*}}
or{{filelist>local/another}}
.fileserver
andlocal
are the aliases defined above and will be replaced accordingly. This makes it easier to type and you can change where all the listings point to at a central location.Note that for the second config no web path is defined. This will use the default PHP dispatcher included in the plugin, eg. PHP will access the file and pipe it through to the browser. No need to have the files in the webserver root anymore.
This should be fully compatible with linux, windows letter style and windows UNC paths and make #38 obsolete.
Docs will be updated once merged. I will keep this open for a bit for feedback.