Use DokuWiki's showuseras setting instead of custom user namespace, fix #151
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the custom user namespace links and replaces the whole custom link generation by standard DokuWiki code. Note that previously the id of the user page was the full name while now it is the user id (if enabled in DokuWiki).
This was referenced Feb 1, 2015
|
As I'm not familiar with GitHub it took me some time to learn how to get the files but now I got them: it's exactly how it's supposed to be:
Only cosmetics: Perhaps there should be a space between the symbol for the user and the user name for there is a space between middot and symbol, too (but this isn't really important). Thanks for your help and fixing! |
michitux
added a commit
that referenced
this pull request
May 16, 2015
Use DokuWiki's `showuseras` setting instead of custom user namespace, fix #151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the custom user namespace links and replaces the whole custom link generation by standard DokuWiki code. Note that previously the id of the user page was the full name while now it is the user id (if enabled in DokuWiki).
This is a change which probably requires action by all people who were using the option to show the user as my guess is that in most cases
showuserasisn't configured to give the behavior that people expect in the footer of the include plugin. Furthermore user pages no longer use the full name of the user but instead the user name as id and this cannot be changed.Therefore I present this change as pull request so you can offer your opinion on this change.