Fixed bug in new Task creation. #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new Task creation form does not use exclamation marks to represent priority but natural language entries from lang[..]. This caused ~~TASK?[priority]~~ entries in pages created by this form to not conform to the syntax and both priority and due date (if given in the form) were not correctly entered. I added a "translation step" before new page creation that should fix this (haven't tested for different languages, but it should work).
|
Hi @JHPeters, But I won't merge your pull-request because I think it's not the optimal way to fix the issue. Instead I corrected the new form dialog to send the priority in the correct form (as it did before, see the function for the old form: _newTaskFormOld(), in helper.php. Also see #35. I think I will create a bugfix release at the weekend. Kind Regards, |
|
I just published a new release. I think this can be closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "new Task" form (on the {{tasks>[namespace]}} page) does not use exclamation marks to
represent priority but natural language entries from lang[..].
This caused
~~TASK?[priority]~~entries in pages created by thisform to not conform to the syntax and both priority and due date
(if given in the form) were not correctly interpreted.
I added a "translation step" before new page creation that should
fix this (haven't tested for different languages, but it should
work).