Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User not being set through CLI #1019

Closed
boblmartens opened this issue Jan 30, 2015 · 5 comments · Fixed by #1418
Closed

User not being set through CLI #1019

boblmartens opened this issue Jan 30, 2015 · 5 comments · Fixed by #1418

Comments

@boblmartens
Copy link

Trying to commit to a page via the CLI results in a "1" being set as the user. It looks like something is happening at inc/cli.php at line 424 where if you supply a user, it will just set it to true and be done. I changed it to 5 for fun and has "5" in the commit logs for the page when supplying a username.

Wondering if this is a known issue when using LDAP as the authentication plugin or something else. Thanks!

@boblmartens
Copy link
Author

Thanks. I'll give this a test and let you know if it is fixed.

@boblmartens
Copy link
Author

I'm now getting this:

E: Unable to obtain lock for [page name]

Even after unlocking I still get that same error message even when not specifying a user. Are there other commits I need to bring over?

@splitbrain splitbrain reopened this Feb 26, 2015
@boblmartens
Copy link
Author

I should also state that I am more than willing to attempt any changes you would like me to do.

@mclei-asw
Copy link

Removing this line from dwpage.php:
$SERVER['REMOTE_USER'] = ''.$this->username.'_';
causes that next "checklock" reports no lock because lock is held by the same user. But in this code it assumes it returns that file is locked correctly.

@yodahome
Copy link

I do get the same problem when trying any commits. When making the commit as root (as it was done usually) the script reports
E: Unable to obtain lock for intern:lmc2:20151014axyz
and when I then use another user it reports
E: Page intern:lmc2:20151014axyz is already locked by another user

Lockfiles seem to be there.
I'm using Release 2015-08-10a "Detritus"

splitbrain added a commit that referenced this issue Jan 19, 2016
* master: (29 commits)
  translation update
  Remaining plugin translations for Welsh (cy)
  Partial Plugin Translation for Welsh
  translation update
  translation update
  Translation of main php lang file: CY
  translation update
  Translation files
  Translation files
  Translation 2
  Translation
  translation update
  translation update
  translation update
  translation update
  translation update
  translation update
  PHP 7 is no longer allowed to fail
  Fixed bug in obtainLock(), where it always fails to verify the lock. This fixes #1019, fixes #1311
  translation update
  ...

Conflicts:
	.travis.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants