Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse search-string and remove parameters before setting $ID #1124

Closed
micgro42 opened this issue Apr 23, 2015 · 0 comments · Fixed by #2286
Closed

Parse search-string and remove parameters before setting $ID #1124

micgro42 opened this issue Apr 23, 2015 · 0 comments · Fixed by #2286
Labels
Category: Backend Feature

Comments

@micgro42
Copy link
Collaborator

Replaces #1123

A search for foo ^bar currently results in the $ID foo_bar, a search for foo ^bar: sets the $ID to foo_bar:start.

It would be more sensible if the search parameters were removed before setting the $ID. Optionally it would make sense to add the namespace if the search is restricted accordingly. E.g. the search-string foo @bar ^bar:test would result in the $ID bar:foo
@micgro42 micgro42 mentioned this issue Apr 23, 2015
Closed
@micgro42 micgro42 mentioned this issue Mar 23, 2018
Merged
21 tasks
micgro42 added a commit that referenced this issue Mar 26, 2018
@micgro42
feat(search): use dedicated url-parameter for search query
d22b78c 
This way we do not loose the context of the current page. Further, the
new id generated from the query before wasn't really that useful (see
issue #1124 ). And we can still generate a meaningful link "create a
page for your query", if that is considered useful.

Further redirects exist for the old urls, so bookmarked searches etc.
should mostly keep working.
micgro42 added a commit that referenced this issue Mar 27, 2018
@micgro42
l10n(search): Add link to create page from query to searchintro
2ce8aff 
Implements the functionality requested in #1124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Backend Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better core search dokuwiki/dokuwiki
3 participants
@splitbrain @Klap-in @micgro42