Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong use of aria-expanded in sidebar #1142

Closed
selfthinker opened this issue May 9, 2015 · 1 comment
Closed

Wrong use of aria-expanded in sidebar #1142

selfthinker opened this issue May 9, 2015 · 1 comment
Assignees
@splitbrain
Labels
Bug Category: CSS XHTML JS Browsers
Milestone
Blockers - coming...

Comments

@selfthinker
Copy link
Collaborator

The use of aria-expanded in the sidebar is wrong. When you inspect the sidebar you will see that basically every child of div.content has an aria-expanded parameter, while that should only be on the div.content.

Also, the animation is on all the children as well instead of the one parent.
@selfthinker selfthinker added the Bug label May 9, 2015
@selfthinker
Copy link
Collaborator Author

Could it have anything to do with this? https://github.com/splitbrain/dokuwiki/blob/master/lib/scripts/page.js#L122

@splitbrain splitbrain self-assigned this Jul 7, 2015
splitbrain added a commit that referenced this issue Jul 18, 2015
@splitbrain
Merge branch 'master' into pagetools
b1a38e2 
* master: (396 commits)
  remote.test
  add a Exception in hasAccess()
  correctly handle usergroups array
  improve aria attribute handling. closes #1142
  remove pragma:no-cache header. closes #1201
  translation update
  translation update
  no syntax highlighting, it attracts too much readers attention
  Better suggestion for changing warning for nosmblink in browsers
  fixed a few links and html errors in language files
  fixed some wrong quotation marks in language files
  fixed occurrences of html named entities in translation files to be xhtml-compatible
  removed English translation strings from non-English translation files
  fixed lots of missing format strings in language files
  refactored tpl_actiondropdown() to avoid duplication
  changed all input type=submit buttons to button type=submit button for better stylability
  translation update
  adjust newline
  translation update
  translation update
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@splitbrain splitbrain

Labels
Bug Category: CSS XHTML JS Browsers
Projects
None yet
Milestone
Blockers - coming release 'Detritus'
Development

No branches or pull requests
3 participants
@splitbrain @selfthinker @Klap-in