Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pagetools-build.php should not be callable from the web #1184

Closed
frankgajda opened this issue Jun 8, 2015 · 4 comments
Closed

pagetools-build.php should not be callable from the web #1184

frankgajda opened this issue Jun 8, 2015 · 4 comments

Comments

@frankgajda
Copy link

Pagetools-build.php should probably not be callable from the web. (Re)building the pagetools-sprite should not be possible/necessary from the web.

@gamma
Copy link
Contributor

gamma commented Jun 8, 2015

It would be great to have this tool or something different available globally - or from admin page or whatever so that plugins can add their own pagetool icons and have them rendered with correct colors.

@Klap-in
Copy link
Collaborator

Klap-in commented Jun 8, 2015

The tool is located in the 'dokuwiki' template folder, so even available locally.
https://github.com/splitbrain/dokuwiki/blob/master/lib/tpl/dokuwiki/images/pagetools-build.php

@splitbrain
Copy link
Collaborator

#874 would solve the problem as it makes use of our new CLI class. It also provides a mechanism for plugin authors to create matching icons.

@splitbrain
Copy link
Collaborator

this has been fixed in b7f0385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants