Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible pagetools icon builder #874

Closed
wants to merge 7 commits into from
Closed

More flexible pagetools icon builder #874

wants to merge 7 commits into from

Conversation

splitbrain
Copy link
Collaborator

This should allow 3rd parties to more easily create their own icons for the pagetools.

This is the missing code for #812

This uses flat icons from the Noun Project now. This is just the first
step.
This can now be used to create arbitrary sprites which is useful for
plugin authors wishing to create their own additional images.
this is not yet supported in the CSS. once it is it should be added to
the builder script.
* master: (396 commits)
  remote.test
  add a Exception in hasAccess()
  correctly handle usergroups array
  improve aria attribute handling. closes #1142
  remove pragma:no-cache header. closes #1201
  translation update
  translation update
  no syntax highlighting, it attracts too much readers attention
  Better suggestion for changing warning for nosmblink in browsers
  fixed a few links and html errors in language files
  fixed some wrong quotation marks in language files
  fixed occurrences of html named entities in translation files to be xhtml-compatible
  removed English translation strings from non-English translation files
  fixed lots of missing format strings in language files
  refactored tpl_actiondropdown() to avoid duplication
  changed all input type=submit buttons to button type=submit button for better stylability
  translation update
  adjust newline
  translation update
  translation update
  ...
not sure if I like it
@splitbrain
Copy link
Collaborator Author

I'm not too happy with the icons I picked in this PR. The line thickness differs too much. I tried to adjust them but that didn't turn out very well either.

@splitbrain
Copy link
Collaborator Author

I replaced the icons with ones from https://materialdesignicons.com/ - it's more consistent now. We could probably use material design icons for all our icons. Including the admin styles and toolbar icons.

@scrutinizer-notifier
Copy link

The inspection completed: 9 new issues, 8 updated code elements

@splitbrain
Copy link
Collaborator Author

I played around with using the icons in the admin menu. Looks pretty good when the correct link color is used....

2015-07-19-154025_792x169_scrot

@splitbrain
Copy link
Collaborator Author

It seems the general mood in the development community is to move from webfonts to (inline) SVG instead. It would make things easier for plugin integration and we wouldn't need to try to deliver a huge font to cover a lot of possibilities.

@splitbrain splitbrain mentioned this pull request Feb 6, 2017
5 tasks
@splitbrain splitbrain closed this Sep 1, 2017
@splitbrain splitbrain deleted the pagetools branch September 1, 2017 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants