Footnotes break metadata abstract saving #1250
Comments
|
This bug is again and duplicated reported (and discussed) in #2383. |
Chris--S
added a commit
that referenced
this issue
May 16, 2018
splitbrain
added a commit
that referenced
this issue
May 17, 2018
* master: fix appveyor, download from https always Issue #1250, associated unit test translation update translation update fix(TASK_RECENTCHANGES_TRIM event): Add isMedia flag rename task event add missing visibility indicator and docblocks translation update refactor: Rename lib/exe/indexer.php to taskrunner.php 🔨 refactor: Move the remainder of code from lib/exe/indexer.php to TaskRunner::run 🔨 Fix for Issue#1250 Footnotes break metadata abstract saving feat: Trigger new event when changelog is trimmed ✨ style(TaskRunner): automatic whitespace fixes 🎨 refactor: Extract code from lib/exe/indexer into new TaskRunner class 🔨 translation update
splitbrain
added a commit
that referenced
this issue
May 18, 2018
* psr2: fix appveyor, download from https always Issue #1250, associated unit test translation update translation update fix(TASK_RECENTCHANGES_TRIM event): Add isMedia flag rename task event add missing visibility indicator and docblocks translation update refactor: Rename lib/exe/indexer.php to taskrunner.php 🔨 refactor: Move the remainder of code from lib/exe/indexer.php to TaskRunner::run 🔨 Fix for Issue#1250 Footnotes break metadata abstract saving feat: Trigger new event when changelog is trimmed ✨ style(TaskRunner): automatic whitespace fixes 🎨 refactor: Extract code from lib/exe/indexer into new TaskRunner class 🔨 corectly disable sniff for one file translation update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
During metadata rendering, an abstract consisting of the first 250 bytes is captured. When a footnote is encountered during this first part of the page, strange things happen. If abstract saving ends inside the footnote, only the text of the footnote is in the abstract. If abstract saving continues, the part before the footnote is restored, but the length of the footnote still counts against the abstract length, so at the end it will be too short.
I think instead of saving away the current text footnotes should rather temporarily disable capturing and re-enable it at the end of the footnote if it was enabled before it (i.e. the state needs to be saved).
The text was updated successfully, but these errors were encountered: