Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimplePie v1.3.1 causes warning in PHP 7 #1800

Closed
ssahara opened this issue Jan 17, 2017 · 1 comment
Closed

SimplePie v1.3.1 causes warning in PHP 7 #1800

ssahara opened this issue Jan 17, 2017 · 1 comment

Comments

@ssahara
Copy link
Collaborator

ssahara commented Jan 17, 2017

PHP warning caused by inc/SimplePie.php after upgrading PHP 7.1,

[07-Jan-2017 21:55:54 Asia/Tokyo] PHP Warning:  A non-numeric value encountered 
in /var/www/sites.d/site2/html/dokuwiki/inc/SimplePie.php on line 15343

Following fix will solve this issue as same as patched in recent SimplePie v1.4.3 which is newer than v.1.3.1 of that current DokuWiki uses.

15343c15343
<                       $second = round($match[6] + $match[7] / pow(10, strlen($match[7])));
---
>                       $second = round((int)$match[6] + (int)$match[7] / pow(10, strlen($match[7])));
@Klap-in
Copy link
Collaborator

Klap-in commented Jan 17, 2017

When updating SimplePie it is handy to consider moving to composer for this as well https://packagist.org/packages/simplepie/simplepie

splitbrain added a commit that referenced this issue Jan 18, 2017
This updates the SimplePie RSS parser to the recent 1.4.3 release,
fixing an PHP 7 bug (and probably others). We now use a composer based
install.
@splitbrain splitbrain modified the milestone: Frusterick Manners Jan 18, 2017
splitbrain added a commit that referenced this issue Feb 3, 2017
updated SimplePie and moved to composer based install. #1800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants