Add missing tbody to renderer #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The inspection completed: 4 new issues, 4 updated code elements |
|
This just adds the methods to the renderer but does not actually implement a heuristic to decide when to have a tbody, right? |
|
Yes, it only adds the methods. (I needed it to write correct HTML for the YouTrack plugin.) As I said, I wanted to write a bug report for using it. I've done that now: #1050 |
splitbrain
added a commit
that referenced
this pull request
Feb 23, 2015
Add missing tbody to renderer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
tabletbody_open()andtabletbody_open()to renderer.(Ideally it should also be fixed that tables have a thead but not a tbody. I'll open a bug report for that later.)