Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally suppress startpage in "You are here" navigation #123

Closed
wants to merge 3 commits into from

Conversation

pah
Copy link
Contributor

@pah pah commented Aug 10, 2012

This pull-request adds an option to slightly change the behaviour of the "You are here" navigation. Especially in combination with $conf["useheading"], the start page may include too much clutter at deeper levels of the site hierarchy. With the additional option, the start page can be suppressed at lower levels.

$conf["youarehere"] now behaves as

  • 0 : off
  • 1 : include start page in navigation (as before)
  • 2 : suppress start page (except on start page)

This patch adds an option to slightly change the behaviour of the
"You are here" navigation.  Especially in combination with
$conf["useheading"], the start page may include too much clutter
 at deeper levels of the site hierarchy.  With the additional option,
the start page can be suppressed at lower levels.

    $conf["youarehere"] now behaves as
     0 : off
     1 : include start page in navigation (as before)
     2 : suppress start page (except on start page)
@bug
Copy link
Collaborator

bug commented Aug 13, 2012

This change brings confusion IMHO. If you want to hide start pages of depths > 1 why not adding a setting for that and not altering the behaviour of the current conf setting? And also, shouldn't your change only happen when useheading is used? and maybe without a conf option at all in this case?

@pah
Copy link
Contributor Author

pah commented Aug 13, 2012

Thanks for your comments. :-)

First of all, it should be noted that the meaning of the current conf setting is not altered (the values 0 and 1 are exactly handled the same way as before). IMHO, this minor choice does not warrant a setting on its own.

I like the idea to make this the default bhhaviour when used together with useheading=navigation|1. If we agree on that, I'll happily update the pull request accordingly.

@selfthinker
Copy link
Collaborator

I don't like this solution. The problem is that you try to solve a design issue by changing the content.

You don't really mind that the home page is in the breadcrumbs, you only mind that it takes up so much space. So, the solution should be around that problem. It's good practice to include the home page in breadcrumbs for usability reasons, so removing it is not a good solution (because breadcrumbs should show the whole progress).

I definitely see the problem, though. But I would rather either simply not use useheading on the home page in the breadcrumbs, or maybe replace it with "Home" (a new lang string) or at least add a special class to it so you can do something visually, like replacing the text with a home icon.

@splitbrain
Copy link
Collaborator

@splitbrain splitbrain closed this Nov 4, 2012
eduardomozart added a commit to eduardomozart/dokuwiki that referenced this pull request Feb 8, 2024
Should not highlight HTML entities - "}" should'nt be parsed as '&dokuwiki#123;' and be rendered as such (see issue dokuwiki#4192).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants