Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deleted files on update of extension #1240

Merged
merged 1 commit into from Jul 27, 2015
Merged

Conversation

Klap-in
Copy link
Collaborator

@Klap-in Klap-in commented Jul 16, 2015

Resolves #1192 by supporting:

/lib/plugins/<plugin>/deleted.files
which list files that can be removed e.g.

# This is a list of files that were present in previous plugin releases
# but were removed later. An up to date plugin should not have any of
# the files installed
action.php
folder/file.txt

Resolves #1192

`/lib/plugins/<plugin>/deleted.files`
which list files that can be removed e.g.
```
# This is a list of files that were present in previous plugin releases
# but were removed later. An up to date plugin should not have any of
# the files installed
action.php
folder/file.txt
```
@scrutinizer-notifier
Copy link

The inspection completed: 1 updated code elements

@Klap-in
Copy link
Collaborator Author

Klap-in commented Jul 16, 2015

Question:

If I install a branch of the ODT plugin via the url-installer of the Extension Plugin, then I got all the included files as duplicated .gz file.
https://github.com/LarsGit223/dokuwiki-plugin-odt/archive/deletedfiles.zip

Can someone reproduce that?

Edit:

  • same behavior for manual upload of .zip and for download of url from extension repository.
    I'm using the last checkout from git in this wiki.
  • other plugins from github are affected as well. None not-github plugins tested.

@splitbrain
Copy link
Collaborator

👍 looks good to me

@Klap-in
Copy link
Collaborator Author

Klap-in commented Jul 27, 2015

Makes this still chance to be included in Detritus? :-)

splitbrain added a commit that referenced this pull request Jul 27, 2015
remove deleted files on update of extension
@splitbrain splitbrain merged commit 874f411 into master Jul 27, 2015
@splitbrain splitbrain deleted the plugindeletedfiles branch July 27, 2015 08:52
@splitbrain
Copy link
Collaborator

sure :-)

@Klap-in
Copy link
Collaborator Author

Klap-in commented Jul 27, 2015

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants