Fix for PHP 7, more debugging output #1373
Conversation
|
The inspection completed: No new issues |
|
|
|
@turnermm: you're correct, I meant preg_replace with /e. The relevant part in your php7 changed functions links above is "preg_replace() function no longer supports "\e" (PREG_REPLACE_EVAL). preg_replace_callback() should be used instead." The LDAP filter code used preg_replace with /e, and that needed to be changed to preg_replace_callback. |
| return preg_replace_callback( | ||
| '/([\x00-\x1F\*\(\)\\\\])/', | ||
| function ($matches) { | ||
| return "\\".join("", unpack("H2", $matches[1])); |
There was a problem hiding this comment.
Hmm the code changes here from 4 to 2 slashes. That's because it's no longer within the preg_replace substitution?
There was a problem hiding this comment.
Yes, I also wondered - this is quite confusing. The old code actually has 5 backslashs, which has to be an error, only 4 are meaningful: it's one backslash that is doubly escaped, once for the inner double quotes, once for the outer single quotes.
Removing the outer quotes from '"\"' yields "\", as can be verified through print('"\"').
"\" is equivalent to "", which cannot be easily verified, since print("\") or the like will give a parsing error.
I verified the equality of the old and the new string via evaluating the following expression, which gives TRUE:
preg_replace('/./e', '"\"', 'x') === preg_replace_callback('/./', function ($matches) { return ""; }, 'x');
There was a problem hiding this comment.
Okay makes sense. I guess ultimately we should have some tests for this function.
|
👍 |
Fix for PHP 7, more debugging output
ghost
deleted the
Hallo, eine Änderung für PHP7-Komptabilität (preg_replace_callback wird nicht mehr unterstützt), zwei Änderungen zur Ausgabe des ldap_error, was sehr hilfreich sein kann. Erfolgreich getestet unter PHP 7.0.0RC5 (LDAP logins funktionieren).