implements a router for the PHP builtin webserver #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP comes with a builtin webserver for development purposes. This adds the needed routing and also enables rewriting compatible to out userewrite=1 setting. It also implements basic access security (denying access to the data directory and similar directories) A PHP based webserver running DokuWiki can now be started with php -S localhost:8000 index.php
|
I've just tested this, this works very well for me and is a great feature. 👍 I have only one question: why do you deny access to install.php? I'm asking because this means that you cannot install the wiki without using a web server (or copying all configuration files from another wiki). I think especially for use cases like DokuWiki on a stick it would be good to be able to execute install.php. |
|
good question. no idea why I excluded it. I updated the script accordingly. |
|
The inspection completed: No new issues |
splitbrain
added a commit
that referenced
this pull request
Jan 29, 2016
implements a router for the PHP builtin webserver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP comes with a builtin webserver for development purposes. This adds
the needed routing and also enables rewriting compatible to out
userewrite=1 setting. It also implements basic access security (denying
access to the data directory and similar directories)
A PHP based webserver running DokuWiki can now be started with
php -S localhost:8000 index.php