Fix case-insensitive match in ACL checking #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACL checking of DokuWiki is currently always case-sensitive regardless of auth backend setting ($auth->isCaseSensitive). This commit enables case-insensitive match in the same way of auth_isMember().
| protected $oldAuth; | ||
| protected $oldAuthAcl; | ||
|
|
||
| function setup() { |
There was a problem hiding this comment.
You should call the parent::setup() method setup DokuWikis test environment.
When doing this you can delete the $this->oldConfig stuff.
There was a problem hiding this comment.
I copied this test file from _test/tests/inc/auth_aclcheck.test.php as a working example, so I didn't notice that the parent::setUp() is recommended.
By the way, almost all test files in _test/tests directory have no parent::setUp(). Do I really need to fix this?
There was a problem hiding this comment.
i would say it's not mandatory but a nice to have ;-)
|
anyway -> 👍 |
|
@dom-mel how about this: I merge this PR and you'll check our test cases for bad style setup() routines? |
|
Yes |
dom-mel
added a commit
that referenced
this pull request
Nov 25, 2012
Fix case-insensitive match in ACL checking
|
Thanks for merging. |
splitbrain
added a commit
that referenced
this pull request
Apr 9, 2020
WIP: Lookups aka Non-Page Tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A modified version of #146.
@ALLgroup