New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken JS in xhtml #1548
Fix broken JS in xhtml #1548
Conversation
Re: the revisionBoxHandler, the issue was only with Re: the footnoteDisplay, the issue was that the content that was put back via
And using that in |
@@ -147,7 +147,7 @@ function document_end() { | |||
} | |||
|
|||
// add footnote markup and close this footnote | |||
$this->doc .= $footnote; | |||
$this->doc .= '<span class="content">'.$footnote.'</span>'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we ever have block elements inside a footnote? If yes, then this should rather be a <div>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we could.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to a div now.
I have to say it's difficult to restrain myself not improving the semantics here. But that makes more sense after the release (and in a different PR).
af97fd4
to
694afa0
Compare
When serving DokuWiki as XHTML there are some JavaScript errors. This fixes most of those errors mentioned in FS#2550.
I'll explain the issues further in the comments below.