Update auth.php #1700
Update auth.php #1700
Conversation
added debug prints to better figure out when LDAP has search issues.
|
@itsho, thanks for your PR! By analyzing the annotation information on this pull request, we identified @splitbrain, @axel-angel and @adrianheine to be potential reviewers |
| // Don't accept more or less than one response | ||
| if ($result['count'] != 1) { | ||
| $this->_debug('LDAP search returned '.htmlspecialchars($result['count']).' results while it should return 1!', -1, __LINE__, __FILE__); | ||
| //for($i = 0; $i < $result["count"]; $i++) { |
There was a problem hiding this comment.
Having code in comments is not good practice. If it was supposed to not be there, better remove it. If it was supposed to be there for debugging purposes but only when actually debugging, remove the comment and add it only if $this->getConf('debug') or if if($this->getConf('debug')).
There was a problem hiding this comment.
I agree. do you want me to remove the code in comment? or you prefer to do it yourself?
There was a problem hiding this comment.
please remove it in an additional commit.
There was a problem hiding this comment.
I might be wrong but seems like someone else already did it.
edit:
I've compared this version with the one in master and it seems that someone indeed already did it.
added debug prints to better figure out when LDAP has search issues.