Updated idfilter() function for IIS #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a condition inside idfilter() function that helps Apache on Windows to properly handle colon as a namespace separator by replacing it with semicolon. However, this is not necessary on Microsoft IIS server so the condition was improved.
|
@Chris--S we had that discussion at #84 already. But since we don't know what other webservers do and this is a problem orgininally coming from the windows filesystem, we decided to keep on the safe side here and use a whitelist instead of a blacklist. We left the version check because we had no test systems available. If @borekb has tested this, I'm fine with merging. |
|
Can we add something in the code to indicate that, at least a link to the discussion log. // white list of browser which don't require this fix - see http://... |
|
agreed. that makes sense |
|
was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to a pull request here: #84. However, this time the fix doesn't contain a specific IIS version number as it seems to be working on all versions (I have personally tested it on IIS 7, 7.5 and 8).