fix problems with header that look falsy. fixes #1770 #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@splitbrain, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Klap-in, @selfthinker and @adrianheine to be potential reviewers. |
|
Ah looks like a limit in metadata rendering bit me. The test succeeds when run on it's own but fails when the whole suite is run. I'll fix it later. |
This took me way to long to figure out. The useheading setting was cached in a static variable which is fine usually as it doesn't change during a single request. But in testing we want to change it often.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.