Updated remote.php #1938
Merged
Updated remote.php #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated remote.php for retrieving all the acl details.
|
@Dharmik8478, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Startouf, @Klap-in and @maBergaoui to be potential reviewers. |
|
can we have some context here? |
By mistake changed in addAcl instead of listAcls.
|
I am getting empty string while making XML-RPC call from my python code for method 'listAcls'. By adding 's' to remote.php it resolved my problem. |
|
From looking at the code i see that it was just a typo - since the content from getMethods should corespondent with the function names. tldr: looks fine for me |
splitbrain
added a commit
that referenced
this pull request
May 13, 2017
* master: fix error in config manager caused by changes visibility Continue if there are no attributes avoid dependency tests being marked as risky replaced some more each calls remove deprecated each() call test constructors need to call parent constructor use dataprovider in password tests removed deprecated blowfish class replace some var keywords translation update PassHash.class.php: in case of brcrypt, use the most recent variant $2y$ translation update Fix Typo in remote API (#1938) translation update translation update translation update use 403 response on bad logins. closes #1937
splitbrain
added a commit
that referenced
this pull request
May 19, 2017
* master: (80 commits) use composer based library for feed creator #1970 fixed typo in methodname updated GeSHi to 1.0.9.0 refomatted mail tests to use data provider fix error in config manager caused by changes visibility Continue if there are no attributes avoid dependency tests being marked as risky replaced some more each calls remove deprecated each() call test constructors need to call parent constructor use dataprovider in password tests removed deprecated blowfish class replace some var keywords translation update PassHash.class.php: in case of brcrypt, use the most recent variant $2y$ translation update Fix Typo in remote API (#1938) translation update translation update translation update ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated remote.php for retrieving all the acl details.