Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added loggedIn class to main tpl container #194

Merged
merged 5 commits into from Aug 1, 2013
Merged

Conversation

selfthinker
Copy link
Collaborator

This is a feature, not a bug fix. And it's in a pull request because it's after feature freeze. But it would be great to have it in the next release anyway.

@selfthinker
Copy link
Collaborator Author

I wonder if it makes sense to introduce something like WordPress's "body_class()", so maybe tpl_template_class()? To have the mode in there makes sense as well, but maybe not the sidebar classes (as some templates might not use them).

@splitbrain
Copy link
Collaborator

I'd be fine with merging this, but yes, a Wordpress like class output function could be useful across different templates.

@selfthinker
Copy link
Collaborator Author

I only planned to keep this quick and simple because I had hoped it would make it into the release. Now that it's after the release, I'm fine with adding an appropriate function instead.

@splitbrain
Copy link
Collaborator

@selfthinker okay, we're waiting for your function

Chris--S added a commit that referenced this pull request Aug 1, 2013
added loggedIn class to main tpl container
@Chris--S Chris--S merged commit 806bda3 into master Aug 1, 2013
@Chris--S Chris--S deleted the loggedin-class branch August 1, 2013 17:56
splitbrain added a commit that referenced this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants