Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly identify AD account #204

Merged
merged 3 commits into from
Apr 19, 2013
Merged

Correctly identify AD account #204

merged 3 commits into from
Apr 19, 2013

Conversation

senorandy
Copy link
Contributor

Without this change, there is no access to AD info. Also allows SSO.

@senorandy
Update default.php
939baf4 
Wihtout this, unable to fetch any AD info.. also allows SSO.
@senorandy
Update metadata.php
0bb7340 
Without this unable to access AD info. Also allows SSO.
@senorandy
Update settings.php
3bca6c6
@lupo49
Copy link
Contributor

lupo49 commented Mar 30, 2013

Is there something missing? There are only language strings modifications committed?

@senorandy
Copy link
Contributor Author

Yep, that's all I did. All that seems to matter is that the 2 variables in local.php (or local.protected.php) contain admin and not ad.. Can anyone test this? For me, With a do=check, the group memberships are listed with this change, and without it, not..

@splitbrain
Copy link
Collaborator

Oh, you're right. adldap expects admin_username as option. I wonder when and why this broke. Maybe the options changed in the 4.x series...

splitbrain added a commit that referenced this pull request Apr 19, 2013
@splitbrain
Merge pull request #204 from senorandy/master
2faa7d7 
Correctly identify AD account
@splitbrain splitbrain merged commit 2faa7d7 into dokuwiki:master Apr 19, 2013
@Klap-in
Copy link
Collaborator

Klap-in commented Apr 20, 2013

i have no setup to test this plugin, but when reading code i see on
https://github.com/splitbrain/dokuwiki/blob/master/lib/plugins/authad/auth.php#L472
usage of ad_username and ad_password, this needs renaming too, isn't?

Or performs the current code ok?

@Klap-in
Copy link
Collaborator

Klap-in commented Apr 21, 2013

This needs to be false:
https://github.com/splitbrain/dokuwiki/blob/master/lib/plugins/authad/auth.php#L475

@splitbrain
Copy link
Collaborator

@Klap-in I pushed another change after merging the pull request which fixed the usage in line 472. Not sure what you mean with the second comment. The line looks fine to me?

@splitbrain
Copy link
Collaborator

ah never mind. I just saw #214

splitbrain pushed a commit that referenced this pull request Apr 9, 2020
@micgro42
fix: Set right class on datetime entry for widget
1707798 
With this the correct class will be set in all the scenarios (page-edit,
inline, lookup). Then changing the date via the datepicker will always
generate time-template as defined in script/EntryEditor.js

Fixes #204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@senorandy @lupo49 @splitbrain @Klap-in