Fix PHP Notices: Reduce error log noise #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While DokuWiki suppresses PHP Notices they are still a code smell and should be fixed. This fixes some PHP Notices that occurred. Some of these fixes could be refactored into nicer code once we move to PHP 7 and get access to the `??` operator.
|
@micgro42, thanks for your PR! By analyzing the history of the files in this pull request, we identified @splitbrain, @selfthinker and @Klap-in to be potential reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core still throws some notices. Even though DokuWiki suppresses them, I think they are worth fixing.
Especially the changes in
/inc/parser/renderer.phpcould be refactored into nicer code once we reach PHP 7 and can access the??operator.However, there are still many Notices being thrown by plugins.
PS: I wrote a small Plugin to display notices and other errors suppressed by DokuWiki. I find it helpful during development.