Changes cursor position to end of inserted image syntax, implements #2079 #2106
Conversation
…eep open' mode)
|
@rsynnest, thanks for your PR! By analyzing the history of the files in this pull request, we identified @selfthinker, @adrianheine and @akate to be potential reviewers. |
lib/scripts/media.js
Outdated
|
|
||
| insertTags(edid, '{{' + alignleft + mediaid + opts + alignright + '|', '}}', ''); | ||
| if (keepopen) { | ||
| insertTags(edid, '{{' + alignleft + mediaid + opts + alignright + '|}}', '', ''); |
There was a problem hiding this comment.
I think after the tag we can add \n\n for better composition. That is:
insertTags(edid, '{{' + alignleft + mediaid + opts + alignright + "|}}\n\n", '', '');
There was a problem hiding this comment.
I would disagree. I often use the feature to insert multiple images into one article but not necessarily one after each other. More like "one here, on there and another there..." having it insert new paragraphs would be counter productive then.
There was a problem hiding this comment.
@splitbrain is right. I ignored this use case before.
Klap-in
changed the title
|
I would like that if the media manager includes just one image (or the latest if you include a couple of images), that it puts the cursor in the just included syntax (the behaviour before this change). My proposal is to check if the cursor is already in a syntax (that is checking if |
|
sure thing, will push an update soon |
…ady inside an image tag If it's already inside an image tag, move the cursor to the end of the current tag.
|
good work. Thanks a lot @rsynnest 👍 |
Changes cursor position to end of text if media manager is in 'keep open' mode for adding multiple images (Issue #2079).