Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest.json for PWA functionality #2163

Conversation

albacoretuna
Copy link

On phones that support progressive web apps, adding dokuwiki to
home screen will make it open in full screen which is nicer.

fixes #2156

@phy25
Copy link
Collaborator

phy25 commented Oct 29, 2017

Just dropping my two cents here, is it necessary to add a new lib/manifest folder? In the long term only one single manifest file is required. Maybe you can merge it into lib/styles folder.

@splitbrain
Copy link
Collaborator

What is the php file for when all you do is deliver a static manifest file? This could be easily done by the web server.

It would make sense to dynamically create the manifest though when using the wiki's title instead of a hard-coded "DokuWiki".

On phones that support progressive web apps, adding dokuwiki to
homescreen will make it open in full screen which is nicer.
@albacoretuna albacoretuna force-pushed the feature/manifest-progressive-web-app branch from 678fea7 to 650b459 Compare October 29, 2017 20:06
@albacoretuna
Copy link
Author

@phy25 thanks for your review. I just thought because it's not a stylesheet it will be confusing to put it in lib/styles

@splitbrain you're right, I just assumed I should exactly follow how jquery is included.

How does it look now?

By the way thanks for acting nicely on my first PR, it was a quick review :)

@micgro42
Copy link
Collaborator

micgro42 commented Nov 1, 2017

I like this a lot! I think starting with a static JSON file is a good idea for now. 🙂

I see many possible extensions for future pull requests:

  • Using DokuWiki's title and tagline, (as suggested by splitbrain)
  • using a placeholder from the style.ini as background color
  • Providing user-defined icons
  • adding a config option to modify the manifest's display key
  • etc.

But again, these are things for the future. Or maybe a plugin that utilizes a metaheader event?

:shipit:

@michitux
Copy link
Collaborator

michitux commented Nov 1, 2017

As it is now, every DokuWiki instance will appear the same unless the admin of that wiki customized that file (which will be reverted on every upgrade). I don't think having this by default with no way to easily disable it (that persists across upgrades) is desirable for any wiki but dokuwiki.org.

I think the feature in general is nice, but I would at least suggest the following features:

  • Use the title and tagline of the wiki so the default is okay for most wikis
  • Use a configuration cascade for finding the JSON file and allow overriding it with a file in the configuration directory (similar to user styles).
  • It would be nice to re-use the existing icon customization options. I think the "apple-touch-icon" should already be the right type/size of icon.

@splitbrain splitbrain added this to the Greebo milestone Nov 26, 2017
@albacoretuna
Copy link
Author

I'll close this in favor of #2241

@albacoretuna albacoretuna deleted the feature/manifest-progressive-web-app branch April 5, 2018 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding manifest.json to make it PWA ?
5 participants