Explicitly transmit codeblock offset accross workflow "Show => Section edit => Preview". #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n edit => Preview". This helps finding the correct codeblock if a code download is triggered in preview mode. Fixes #741.
phy25
reviewed
Dec 25, 2017
inc/html.php
Outdated
| @@ -126,6 +126,10 @@ function html_secedit_button($matches){ | |||
| $data['name'] = $matches['name']; | |||
| } | |||
|
|
|||
| if (!empty($matches['codeblockOffset'])) { | |||
| $data['codeblockOffset'] = strtolower($matches['codeblockOffset']); | |||
There was a problem hiding this comment.
strtolower() seems unnecessary.
There was a problem hiding this comment.
True, copy&paste leftover...changed it.
|
In general I'm fine with this PR, however I think the way we markup the sections gets a bit complicated. I think it would be time to refactor this a bit:
When implementing this, we need to check if plugins implementing a custom editor (data, edittable, ...) need any adjustments. |
|
I will leave this as is and handle the refactoring in branch |
|
I guess we can close this in favour of #2220? |
|
Yes! I'll close it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps finding the correct codeblock if a code download is triggered in preview mode. Fixes #741.