feat: make auth salt static in test environments #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are circumstances where we may want to test generated content that uses the auth salt, for example when one tests the rendering of external images where the url contains a token from media_get_token
|
No idea if it applies here, but an empty string could be evaluated as false if it is compared loosely. |
As pointed out by @Klap-in, an empty string may evaluate to false in some circumstances. This is something we may not want. Using a string like 'test' should therefore be more robust.
micgro42
added a commit
to cosmocode/dokuwiki-plugin-prosemirror
that referenced
this pull request
May 29, 2018
This was made possible by the inclusion of dokuwiki/dokuwiki#2273 into the Greebo release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are circumstances where we may want to test generated content that
uses the auth salt, for example when one tests the rendering of external
images where the URL contains a token from media_get_token