-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSR 2 Adoption #2358
Merged
Merged
PSR 2 Adoption #2358
Changes from 1 commit
Commits
Show all changes
185 commits
Select commit
Hold shift + click to select a range
994e9d4
added php code sniffer config
splitbrain ffa824e
removed obsolete CS setup
splitbrain b4f2363
remove DOKU_INC checks
splitbrain 4b3d170
do not check for namespace use, yet
splitbrain 99c1e5d
disable some sniffs on things we can not change
splitbrain 09d57d5
adldap is a 3rd party lib
splitbrain 64159a6
line lengths shortened
splitbrain aba86f3
visibility fixes
splitbrain 3dc2d50
visibility declarations in plugins
splitbrain 42c2870
plugin prototype adjustments
splitbrain a087da7
fixed broken tests
splitbrain d2778ca
correctly autoload the parser stuff
splitbrain de36992
visibility definition for the renderers
splitbrain 36dc94b
split out parser modes into their own files
splitbrain e6686e8
fixed wrong quoting
splitbrain 5c2aad1
split handler.php into multiple files
splitbrain ffc2cc4
Merge branch 'master' into psr2
splitbrain 47f73ec
adjusted Doku_Parser for PSR-2
splitbrain de22611
adjusted the Lexer for PSR-2
splitbrain 836f6ef
add methods to test interal properties
splitbrain 8b1b81b
cleaned up Doku_Handler for PSR-2
splitbrain e9eace7
rename invokeParser to invokeHandler
splitbrain be906b5
moved all parsing related namespaces to their own
splitbrain d4d8fb1
moved Parser to Parsing namespace
splitbrain 23f4cc4
do not use DOKU_PARSER_EOL outside of testing
splitbrain e1cdd96
some more visibility declarations
splitbrain dd87735
PSR-2 compatibility for the remote API libs
splitbrain 4cdb684
started a dedicated file for deprecated stuff
splitbrain 272a98e
Merge branch 'master' into psr2
splitbrain 1cdd009
moved XMLRPC server class from lib/exe to inc/Remote
splitbrain 29fc53c
PSR-2 for popularity plugin
splitbrain 957f36a
PSR-2 compatibility for info plugin
splitbrain 3213bf4
PSR-2 for authpdo plugin
splitbrain d0a7b19
fixed class name
splitbrain 18b1e90
PSR-2 for extension plugin
splitbrain e79ce39
adjusted phpcs config for plugins
splitbrain 82f7cb0
adjust remote plugin handling in code check
splitbrain 71a75f0
PSR2 for styling plugin
splitbrain a433732
PSR-2 for authad plugin
splitbrain 661d78e
PSR-2 for safefnrecode plugin
splitbrain 5aa905e
PSR-2 for authplain plugin
splitbrain fdf613b
fixed auth plain test
splitbrain a4e3d55
PSR-2 for ACL plugin
splitbrain d17fc5d
PSR-2 for authldap plugin
splitbrain 3a97d93
PSR-2 for usermanager plugin
splitbrain 2a7fef4
PSR-2 for revert plugin
splitbrain a390de9
Merge branch 'master' into psr2
splitbrain c6639e6
start of refactoring the config plugin
splitbrain e063bab
moved php parser to it's own file
splitbrain 6850fd4
created a configuration Loader class
splitbrain 8ea5685
moved the whole settings class mechanism to it's own class
splitbrain 5a38a12
added Writer class for saving the config back to file
splitbrain 077c27b
adjusted basic loading saving in admin
splitbrain 5675a07
moved language loading to the loader
splitbrain a017dff
introduce getType for Settings
splitbrain 5c17d2d
first go over the settings classes for PSR-2
splitbrain a1ef8b4
PSR2 adjustments for admin class
splitbrain edba97f
fixed the minimal tests we have
splitbrain ced9623
corectly disable sniff for one file
splitbrain d9d27cd
Merge branch 'master' into psr2
splitbrain de33cda
Merge branch 'psr2' into psr2-config
splitbrain be1cc9a
replaced ptln() with echo
splitbrain 0a5b05e
Moved settings to their own namespace
splitbrain 70b28bc
check for opcache function before using it
splitbrain d7e6f39
Merge branch 'testinit' into psr2-config
splitbrain eb1b595
basic test for the Writer class
splitbrain e98b5e4
sucess is green
splitbrain 5d703e3
Also allow test files ending in Test.php
splitbrain f00299d
extract save checking into own method
splitbrain af40dea
proper defaults for initialize
splitbrain 98a151b
Some first Setting class tests
splitbrain c73b800
some more tests on the output mechanism
splitbrain 661c1dd
Make lexer/state stack more understandable
Chris--S 91109d5
Fixed some bugs in the Loader and added tests
splitbrain 8eb28c6
Merge branch 'master' into psr2
splitbrain 303ffdf
Merge branch 'psr2' into psr2-config
splitbrain d6fc72e
fix language and TOC handling
splitbrain 6dd8fd8
some more testing
splitbrain 28cc4f4
make the onoff setting more boolean
splitbrain d6987bd
fixed updateSettings iteration
splitbrain e901cf7
make abstract test abstract again
splitbrain 8356fe6
improve update() comments
Chris--S 5f43ccc
Merge pull request #2404 from splitbrain/psr2-config-update-comments
splitbrain f37fd93
fix numericopt setting
splitbrain 53f3816
do not drop undefined settings when saving the configuration
splitbrain 80302b1
readd PLUGIN_CONFIG_PLUGINLIST event
splitbrain 3b223df
pass correct array in event
splitbrain 13b5250
removed constructor parameters we never use
splitbrain 4667676
clean settings data
splitbrain fbe5f61
removed fixme that had been fixed
splitbrain e729604
make undefined settings output work again
splitbrain 7a0ee53
show other errors in undefined settings again
splitbrain b71f246
an empty class is valid, only truly no class is bad
splitbrain f74addc
remove support for _cautionList
splitbrain a6e1db4
fallback classes for plugins inheriting from old settings classes
splitbrain f8dcd5b
do not initialize the configuration in constructor
splitbrain c68e269
Merge pull request #2382 from splitbrain/psr2-config
splitbrain 2b2d0ba
PSR2 adjustments for bin scripts
splitbrain 1a953a5
ignore side effects in a few more files
splitbrain 9ddafce
Merge branch 'master' into psr2
splitbrain 1696f72
remove debugging stuff from detail.php
splitbrain 432adb3
split sitemapping into its own namespace
splitbrain 0c3a570
split changelog classes into their own namespace
splitbrain b78f68b
some small fixes for PSR2
splitbrain 4da1351
change marquee headline to building for the future
Chris--S 91a976f
Revert previous commit (made in error)
Chris--S 3409ba7
fixed popularity plugin
splitbrain 277113f
Merge branch 'master' into psr2
splitbrain d443762
deprecated JSON class
splitbrain 3aa984a
metadata.php: applied PSR2 Coding Style Guide
lpaulsen93 33361a1
Merge pull request #2653 from LarsGit223/psr2
splitbrain 0db5771
Refactor cache.php into different files
micgro42 42c00b4
Rename methods to conform with PSR 2
micgro42 72c2bae
Fix typo and rename method in comments too
micgro42 43ff105
Adjust comment to better reflect method
micgro42 d2f1d7a
Rename fields and add deprecated __get/__set
micgro42 fec08cc
Use DokuWiki's own deprecation reporters
micgro42 923e149
Merge branch 'master' into psr2
micgro42 1f4834b
Merge pull request #2697 from splitbrain/master2psr2
splitbrain b196d8d
don't apply any memory limits when running code sniffer
splitbrain ccc4c71
adjusted the Input clases for PSR2
splitbrain 2140e75
Merge branch 'master' into psr2
splitbrain 2ed72d0
rename Ajax Callbacks for PSR2
splitbrain b4b0b31
Use deprecation helper
micgro42 963c693
PSR2 adjustments for SafeFN
splitbrain dd8af03
ignore more files in code sniffer configuration
splitbrain c472ace
PSR2 cleanup for the feedparser override
splitbrain e24a74c
PSR2 style fixes
splitbrain dc7da77
Use setter instead of deprecate public property
micgro42 0c5eb5e
Refactor deprecation logging into its own class
micgro42 27cff89
Remove PHP user deprecation errors
micgro42 d8b4928
Merge pull request #2689 from splitbrain/refactorCachePSR2
splitbrain c3cc6e0
PSR2 adjustments for the PassHash class
splitbrain e9f4a0f
Merge branch 'master' into psr2
splitbrain 198564a
Refactor HTTPClient into different files
micgro42 60b9af7
Move deprecated HTTPClient classes to deprecated.php
micgro42 0efa8d1
Rename protected methods for PSR2
micgro42 5a8d6e4
Rename HTTPClient namespace to HTTP
micgro42 5f3a457
Merge pull request #2725 from splitbrain/refctorHTTPCLient
splitbrain abc9c0d
Merge branch 'master' into psr2
splitbrain 2402e44
avoide codesniff warnings on deliberate switch fallthrough
splitbrain 749c002
some PSR-2 fixes for the Mailer class
splitbrain e1d9dcc
First go at moving the plugin classes into their own namespace
splitbrain cbb44ea
deprecated trigger_event() in favor of a static method on Event
splitbrain c630f65
removed deleted file from autoloader
splitbrain 3a7140a
moved plugin controller to Extension namespace
splitbrain 2a93a6a
fix type hints
splitbrain f219f38
removed get_directory() method from PluginController
splitbrain fbccc3e
isEnabled instead of isDisabled
splitbrain 89614c8
Avoid processing events before the Event System is intiialized
splitbrain fdf261b
Avoid accessing the evet system before it's intialized
splitbrain 479c05b
♻️ Extract subscription classes for PSR 2
micgro42 47de339
✅ Fix Subscriptions tests
micgro42 9c22b77
Automatic code style fixes for subscription classes
micgro42 75d6649
♻️ Don't use deprecated subscription methods
micgro42 1935a89
Move list of plugin types to plugin controller constant
splitbrain 42f12f7
snake to camel case fixes in EventHandler
splitbrain 7c9b63b
minor code simplification
splitbrain 091ad7b
Fix snake->camel case, doc blocks
splitbrain c904b9f
Snake to Camel case fixes inn PluginController
splitbrain c47e666
Minor optimizations in PluginController
splitbrain 704a815
♻️ Split up ChangesSubscriptionSender into multiple classes
micgro42 451969a
🚚 Move Subscription class to deprecated.php
micgro42 b8c09b6
Merge pull request #2759 from splitbrain/refactorSubscriptions
splitbrain 820934d
Merge branch 'psr2-pluginredux' into psr2
splitbrain 1dce047
adjust phpcs exclude patterns for new plugin classes
splitbrain 0aace2b
Remove obsolete include
splitbrain 68f88d3
Use type safe comparisons in loader
splitbrain f425155
Ignore mixed concerns in loader
splitbrain 1306777
Create separate table files for UTF-8 handling
splitbrain f41bbe4
Moved all utf8 methods to their own namespaced classes
splitbrain 0da4ba1
Some cleanup for the UTF-8 stuff
splitbrain 27f63a2
some more PSR2 cleanup
splitbrain 0a8df03
mark old utf8 functions deprecated
splitbrain ffdb593
formatting cleanup
splitbrain 8cbc5ee
replaced deprecated utf8 functions
splitbrain 2b9c4a0
Merge branch 'master' into psr2
splitbrain 9eeeb77
fix PSR2 error in switch statement
splitbrain f600e75
ignore PSR2 in the old form class
splitbrain b47790f
Merge branch 'utf8refactor' into psr2
splitbrain 6ce3e5f
fixed some line length errors
splitbrain 8a9a2e3
ignore snake_case error of substr_replace
splitbrain dbc189b
Moved parts of the Asian word handling to its own class
splitbrain 42c62e5
fixed merge error
splitbrain c0c77cd
Merge branch 'master' into psr2
splitbrain File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single quotes and double quotes are combined.