add logic if the server uses unlimited memory, memory_limit = -1 #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splitbrain
added a commit
that referenced
this pull request
Apr 24, 2019
This refactors the php_to_byte() method to properly return integers always. A bug when reading byte sizes under 10 bytes was fixed. Infinity (signaled by a -1 in php.ini) is now returned as -1. According to [1] PHP supports size shortcuts for (K)ilobytes, (M)egabytes and (G)igagbytes only. The support for Tera- and Petabytes has been removed. [1] https://www.php.net/manual/en/faq.using.php#faq.using.shorthandbytes
splitbrain
added a commit
that referenced
this pull request
Jul 14, 2019
* master: (34 commits) fix color for noninstalled extensions show disabled extensions in gray warn about inaccessible repo api bugfix: access check was never cached First go on a CLI component for the extension manager use strict type comparison translation update translation update fix #dokuwiki__sitetools current item not in highlight due to Greebo change authplain: Add tests for group retrieval authplain: Add a simple method for retrieving user groups translation update Negative string offsets are allowed in PHP 7.1+ only improve memory check output fix and test php_to_byte() related to #2756 #2556 translation update translation update translation update translation update translation update ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes warning in do=check (#2474)
see also #2420 which fixed the part happened by scaling images