obfuscate: use utf8_tohtml for hex mode encoding #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful when every character needs to be converted to HTML entities, e.g. (email) `obfuscate()`. Respective test has also been added.
Note that its output for "regular" char (codepoint < 2bytes) has also changed (before hex, now decimal), due to the current behavior of utf8_tohtml. In this case, the config value "hex" doesn't mean "hex" anymore, but it still obfuscates characters as numbers, as expected. This might need doc update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2665.
In order to implement this,
utf8_tohtmladds a $all param to encode everything not utf8 (default false).Note that obfuscate's output for "regular" char (codepoint < 2bytes) has also changed (before hex, now decimal), due to the current behavior of
utf8_tohtml(). In this case, the config value "hex" doesn't mean "hex" anymore, but it still obfuscates characters as numbers, as expected (see changedcommon_obfuscate.test.php). It might need doc update to explain hex is no longer "hex" if this gets accepted.