Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tpl_getMediaFile() #2684

Merged
merged 3 commits into from May 31, 2020
Merged

Improve tpl_getMediaFile() #2684

merged 3 commits into from May 31, 2020

Commits on Oct 21, 2019

  1. Improve tpl_getMediaFile() 

    Previously, if no candidate is found, the result would still always be last candidate url even if it doesn't exist (and function would trigger a Warning for trying to getimagesize() on a file that doesn't exist)
    @geekitude @phy25
    geekitude authored and phy25 committed Oct 21, 2019
    Copy the full SHA
    ca5b6a6 View commit details
    Browse the repository at this point in the history

  2. Update template.php 

    Here is a solution attempt, sorry for the long delay.
According to my tests, absolute path isn't required
    @geekitude @phy25
    geekitude authored and phy25 committed Oct 21, 2019
    Copy the full SHA
    08a1326 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2019

  1. Update template.php 

    Kind of applied given suggestion but switched $fallback to boolean to reduce possible values.
    @geekitude
    geekitude committed Oct 22, 2019
    Copy the full SHA
    c238d75 View commit details
    Browse the repository at this point in the history