Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force Travis CI PHPUnit version to 7 for PHP 7.2+ #2698

Merged
merged 6 commits into from Feb 18, 2019
Merged

Force Travis CI PHPUnit version to 7 for PHP 7.2+ #2698

merged 6 commits into from Feb 18, 2019

Conversation

phy25
Copy link
Collaborator

@phy25 phy25 commented Feb 15, 2019 •
edited

This patch does the following:

  • Add PHP 7.3 (nightly before) to main version list
  • Force PHPUnit version to 7 for PHP 7.2+ (and nightly)
  • Remove HHVM test that will fail forever (see comment for more information)
  • Display PHPUnit version before running the actual test
  • Write notice about PHPUnit version in composer.json suggest field

@phy25
Figure out how to write bash statement for hhvm
96a388f
@phy25
Try to mitigate HHVM's aggressive syntax for tests
6de1ce5
@phy25
Completely remove HHVM for testing
4dd296f 
> Fatal error: Uncaught Error: & is not allowed in write context in phar://phpunit-5.6.8.phar/php-file-iterator/Iterator.php:60

> Fatal error: Uncaught Error: array_creation_expression is not allowed in write context in phar://phpunit-7.5.4.phar/phpunit/Framework/Constraint/JsonMatches.php:54

facebook/hhvm#8387
@phy25
Copy link
Collaborator Author

phy25 commented Feb 15, 2019

I attempted to fix HHVM test, but maybe it's time to say goodbye. So that test is removed completely.

Fatal error: Uncaught Error: & is not allowed in write context in phar://phpunit-5.6.8.phar/php-file-iterator/Iterator.php:60

Fatal error: Uncaught Error: array_creation_expression is not allowed in write context in phar://phpunit-7.5.4.phar/phpunit/Framework/Constraint/JsonMatches.php:54

See also facebook/hhvm#8387 (they have no intention to support these any more).

@phy25 phy25 marked this pull request as ready for review February 15, 2019 02:46
micgro42
micgro42 approved these changes Feb 15, 2019
View reviewed changes
Copy link
Collaborator

@micgro42 micgro42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and seems to work on Travis 👍

.travis.yml Outdated Show resolved Hide resolved
@micgro42 micgro42 merged commit dd34b00 into master Feb 18, 2019
@phy25 phy25 deleted the ci-phpunit-8 branch March 14, 2019 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micgro42 micgro42 micgro42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phy25 @micgro42