Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defective transplantation of _export from .htaccess #2703

Merged
merged 1 commit into from Feb 20, 2019
Merged

Defective transplantation of _export from .htaccess #2703

merged 1 commit into from Feb 20, 2019

Conversation

Rainbow-Spike
Copy link
Contributor

@Rainbow-Spike Rainbow-Spike commented Feb 20, 2019

Ебаный стыд ≺(⊙⁔(\)≻

Ебаный стыд ≺(⊙⁔(\)≻
Copy link
Collaborator

@phy25 phy25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks! (Honestly I have to use Google Translate to understand that...)

@splitbrain splitbrain merged commit 79620db into dokuwiki:master Feb 20, 2019
@Klap-in
Copy link
Collaborator

Klap-in commented Jun 8, 2020

For the changelog, I don't understand that the title states redirecting via .htaccess, but the code mentions the PHP's inbuilt server. Or is that inbuilt server also using .htaccess?

@splitbrain
Copy link
Collaborator

splitbrain commented Jun 8, 2020

@Klap-in yeah this has nothing to do with .htaccess really.

However that part of the code reimplments the rewrites that you'd ususally do via .htaccess in PHP. Which means you can set your userewrite setting to .htaccess and it will work with the builtin server despite it not reading any .htaccess files.

@Rainbow-Spike Rainbow-Spike deleted the patch-1 branch June 9, 2020 08:45
@Rainbow-Spike
Copy link
Contributor Author

Rainbow-Spike commented Jun 9, 2020

I think it's for hostings where you can not config .htaccess main file directly. This is such a rare case that it is not surprising how such a noticeable bug could survive so much

I love DokuWiki ≺(⊙‿‿⊙)≻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants