tests and fixes for set_doku_pref issues

[phy25]

A fix for #2721.

• PHP tests added
• Read last entries (if duplicate) when get
• Remove duplicate entries when set
• Type-aware compare to decide append or modify
• Remove $cookieVal empty check before setcookie, because there might be cases when we want to remove cookie

Also a JavaScript cookie patch: Convert value type to string to prevent different type being returned by DokuCookie.getValue().

DokuCookie.setValue('foo', false);
console.log(DokuCookie.getValue('foo')); // buggy false, should be 'false'
location.reload(); // pseudo code
console.log(DokuCookie.getValue('foo')); // 'false'

AppVeyor is failing just because it doesn't like styleutils_cssstyleini_test::test_mergedstyleini in another PR.

[splitbrain]

The PHP part looks good, I'm not so sure about the JavaScript. Ideally the PHP and JavaScript should behave exactly the same. So setting something to false should delete the cookie instead of setting it to 'false' shouldn't it? And we probably would need to add the second parameter for setting a default to DokuCookie.getValue(). Are we relying on false being turned to 'false' somewhere?

[phy25]

So setting something to false should delete the cookie instead of setting it to 'false' shouldn't it?

Didn't realize this when I use false instead of true as an example. However, I am not sure if this is a breaking change.

And we probably would need to add the second parameter for setting a default to DokuCookie.getValue().

Currently it returns undefined. I am for it.

Are we relying on false being turned to 'false' somewhere?

I am not sure why false->'false' is relied on currently. If we read from cookies, DokuCookie.getValue() always returns string, so this patch makes it consistent when DokuCookie.setValue() and DokuCookie.getValue() are being run in the same page session.

[Klap-in]

Current usage according to Codesearch:

• set_doku_pref
• get_doku_pref
• DokuCookie setValue
• DokuCookie getValue

[phy25]

I went through DokuCookie.setValue and DokuCookie.getValue in codebase, and it looks like developers use "" a lot. Nobody uses false.

So...

• Setting something to false should delete the cookie instead of setting it to 'false' - fe36a27
• add the second parameter for setting a default to DokuCookie.getValue() - bded2f5

As I mentioned, the only thing that hasn't been addressed yet, is that I don't understand "Are we relying on false being turned to 'false' somewhere"...

[splitbrain]

What I meant with "Are we relying on false being turned to 'false' somewhere" is that I wasn't sure if any plugin maybe sets a cookie to false and expects to get a string of 'false' later on to do something with that. Judging from the code search results nobody seems to do that, so this should be good.

[Klap-in]

Manual tests for javascript: see #2721 (comment)