Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor HTTPClient to conform with PSR2 #2725

Merged
merged 4 commits into from Mar 30, 2019
Merged

Refactor HTTPClient to conform with PSR2 #2725

merged 4 commits into from Mar 30, 2019

Conversation

micgro42
Copy link
Collaborator

No description provided.

@splitbrain
Copy link
Collaborator

Looks good, but I wonder if we should use dokuwiki\HTTP\Client instead of dokuwiki\HTTPClient\HTTPClient?

@micgro42
Copy link
Collaborator Author

Looks good, but I wonder if we should use dokuwiki\HTTP\Client instead of dokuwiki\HTTPClient\HTTPClient?

Sounds good! That would give us the option to later move functionality from inc/httputils.php there as well.

I'll try to look into this next week :)

@micgro42
Rename HTTPClient namespace to HTTP
5a8d6e4 
This should make namespace a bit more flexible in scope and allow us to
move more functionality there later.
@splitbrain splitbrain merged commit 5f3a457 into psr2 Mar 30, 2019
@splitbrain splitbrain deleted the refctorHTTPCLient branch March 30, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splitbrain splitbrain Awaiting requested review from splitbrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@micgro42 @splitbrain