Fix/Harmonize inconsistent Tag names that lead to reporting wrong dates. #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phy25
approved these changes
Jun 5, 2019
There was a problem hiding this comment.
Thank you! Also edited docs on https://www.dokuwiki.org/devel:templates:detail.php, and I will also generate a PR on https://github.com/sd/jpeg-php
|
Opps, https://github.com/sd/jpeg-php already lags a lot from here. Will send changes to there as a whole. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why
tpl_img_getTag('Date.EarliestTime');
was reporting wrong dates: File modification date instead of the ealier EXIF:DateTimeOriginal.
I found the bug in JpegMeta.php where the tag is referred to as "DateTimeOriginal" in one part, but as "DatetimeOriginal" in the other part of the script. Fixing the name in the EXIF tag name definition to
This fixes #2784.