authpdo: Add multi-rowset support and fix mybb test #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure if user defined multiple query in one SQL, they are all executed rather than only the first one.
https://dev.mysql.com/doc/refman/5.7/en/upgrading-from-previous-series.html > In MySQL 5.7.5, these SQL mode changes were made: ... Strict SQL mode for transactional storage engines (`STRICT_TRANS_TABLES`) is now enabled by default. https://dev.mysql.com/doc/refman/5.7/en/data-type-defaults.html > For data entry into a NOT NULL column that has no explicit DEFAULT clause, if an INSERT or REPLACE statement includes no value for the column, or an UPDATE statement sets the column to NULL, MySQL handles the column according to the SQL mode in effect at the time: > > If strict SQL mode is enabled, an error occurs for transactional tables and the statement is rolled back. For nontransactional tables, an error occurs, but if this happens for the second or subsequent row of a multiple-row statement, the preceding rows will have been inserted.
This was referenced Sep 16, 2019
|
Ping: If anyone can give this a review, we can resolve the current failing tests 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure if user defined multiple query in one SQL, they are all executed rather than only the first one.
https://dev.mysql.com/doc/refman/5.7/en/upgrading-from-previous-series.html
One thing I am not sure is whether it's safe to use
nextRowset()since I read about various support about this feature which make it sometimes broken.Fixes #2841.
Remaining task is to adapt to nightly PHP 8: 439cabd, b53f188