Fix issue #2883 #2886
Merged
Fix issue #2883 #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splitbrain
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
I'd be okay with merging this. I added some additional background info in the #2883 ticket.
Ideally, I would want to see the IXR library moved to a composer dependency. That dependency could be based on kissifrot/php-ixr but with added tests, doc block comments and maybe fixes incorporated from wordpress and/or others (We'd have to check our own commit history on that). However this would be a completely new project and I guess that's a bit more than what @mpcjansen was looking for here ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue that incorrect date format is used in XMLRPC responses (issue #2883).
This is the cleaned up result of the discussion at PR #2885.