GitHub workflow adjustments #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make the code style checks also run on pull requests the come from forks. Maybe also on old pull requests?
micgro42
force-pushed
the
workflowAdjustments
branch
2 times, most recently
from
9472f2c
to
f16368f
Compare
|
Looks good to me, though personally I would like to keep allowing |
|
Mh, PSR-2 does say:
PSR-12 is even a bit more verbose. That being said, we are free to diverge from PSR as we like. We are creating our own code style after all :) |
Splitting them out allows for plugins to use _test/phpcs.xml as the basis for their own linting without having an overly permissive coding standard. Also, this makes it more obvious and painful that these are just intended as temporary exceptions and should be actually fixed. The rule `Generic.ControlStructures.InlineControlStructure.NotAllowed` has its comment adjust to make it clear that this is an intended deviation from the PSR-2/PSR-12 coding standard. The rule `PSR1.Classes.ClassDeclaration.MissingNamespace` has to remain in the DokuWiki coding standard as the plugin base classes can currently not reasonably be in namespaces.
micgro42
force-pushed
the
workflowAdjustments
branch
from
f16368f
to
36faf69
Compare
phy25
approved these changes
Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable plugins to natively run PHP Code Sniffer checks against the actual DokuWiki standard and not against a version that has been watered down until we have gotten around to fixing all the violations.
An example for such a workflow can be found with the struct section plugin: .github/workflows/phpCS.yml.
(Notice that this file is suitable to be included in the plugin-wizard)
PS: It is currently not reasonably possible to add namespaces to the classes like
action_plugin_structsection. I wonder if we could at some point refactor the plugin system to support this?