Defer javascript and add feature Flag #2974
Conversation
GooglePage Speed Insights rank up 5-10 points Otherwise, the browser render is waiting for loading and compiling big CDN script libraries
This adds a feature flag for the jQuery and main-js requests added in #2786 and #2958. This adds only a single feature flag since deferring jQuery without deferring the main javascript request is likely to cause errors and confusion. The feature flag defaults to "on" as this should be unproblematic except for a few plugins. Also, with this flag being on by default, it should see more usage and is more likely to uncover existing issues. This feature flag should be removed once this feature is deemed safe.
|
[V] |
| @@ -230,6 +230,9 @@ | |||
| $meta['search_fragment'] = array('multichoice','_choices' => array('exact', 'starts_with', 'ends_with', 'contains'),); | |||
| $meta['trustedproxy'] = array('regex'); | |||
|
|
|||
| $meta['_feature_flags'] = ['fieldset']; | |||
There was a problem hiding this comment.
Does it make sense to add a new config section for this? I would have added it to the "Advanced" section. OTOH, if we do add a new section, it might make sense to rearrange some other settings as well?
There was a problem hiding this comment.
I created that Feature Flag section to indicate that these Feature Flags are about to be dropped again soon. Maybe already before the next release, maybe only for the release after that.
To my understanding, Feature Flags are a specific pattern for rolling out features safely. https://en.wikipedia.org/wiki/Feature_toggle
It is not intended to permanently provide the ability to turn these features off, only until we are sure that we are not breaking too much.
If we want to make this a permanent toggle, then it should indeed be integrated into the "advanced" section. But I'm not sure I see the need for that?
|
Todo: Document feature flags, and this specific flag. |
|
Who could create this page: https://www.dokuwiki.org/config:defer_js ? |
|
I started the page. Feel free to improve. |
This builds upon the pull requests #2786 and #2958 by @Dr-Yukon and adds a feature flag for the defer attribute added to the jQuery and main-js requests in these pull requests. It adds only a single feature flag since deferring jQuery without deferring the main javascript request is likely to cause errors and confusion.
The feature flag defaults to "on" as this should be unproblematic except for a few plugins. Also, with this flag being on by default, it should see more usage and is more likely to uncover existing issues.
This feature flag should be removed once this feature is deemed safe.
Closes #2786
Closes #2958