Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent capilization of io_saveFile and psr-2 formatting #2992

Merged
merged 2 commits into from Mar 4, 2020
Merged

Consistent capilization of io_saveFile and psr-2 formatting #2992

merged 2 commits into from Mar 4, 2020

Conversation

kalenpw
Copy link
Contributor

@kalenpw kalenpw commented Feb 29, 2020 •
edited by phy25

Saw this #2937 was still unresolved and figured it would be an easy first pull request. Also fixed formatting of the files I touched.

Fixes #2937.

@phy25
Copy link
Collaborator

phy25 commented Feb 29, 2020

Do you mind replacing the deprecated dokuwiki\Cache\Cache::$_event calls that Scrutinizer check mentions as well?

@kalenpw
Copy link
Contributor Author

kalenpw commented Feb 29, 2020

Yep, just corrected that.

@splitbrain splitbrain merged commit ef2fb1a into dokuwiki:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phy25 phy25 phy25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

io_savefile possibly f in stead of capital F ?
3 participants
@kalenpw @phy25 @splitbrain