Prevent double encoding audio/video titles #2994
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{video.mp4|Single quote: ' Ampersand: &}}
Audio/video files like the above will have double-encoded HTML entities showing in their
title
attribute.This fixes that by removing an unnecessary
_xmlEntities()
call.The title gets escaped later by
_audio()
/_video()
which passes it throughbuildAttributes()
:https://github.com/splitbrain/dokuwiki/blob/c22dd092c4c44d7d648d88cb32606880af5156c7/inc/parser/xhtml.php#L1871
https://github.com/splitbrain/dokuwiki/blob/246d33375d7a319f09d2b596725e38a48dd90794/inc/common.php#L376