add overwrite option on extension upload form #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, on frontend $overwrite is false. Backend function installFromUpload / installFromURL will have a default of true to preserve existing behavior for other API users. installArchive now will insert a frontend msg() about not installing because of overwrite restriction. It's not being exposed by exception, but it should be reflected on its return array list of installed plugin. This fixes #715.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, on frontend $overwrite is false. Backend function installFromUpload / installFromURL will have a default of true to preserve existing behavior for other API users.
installArchive now will insert a frontend msg() about not installing because of overwrite restriction. It's not being exposed by exception, but it should be reflected on its return array list of installed plugin.
This fixes #715.