refactor page and media resolving, introduce ~ shortcut #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the resolve_id() type of functions into their own class hierarchy. A new shortcut to be used in links is introduced. The tilde ~ can be used to reference the current page as a namespace. This is useful to dynamically create a new namespace from an existing page, effectively making that page the start page. It allows for a more dynamic growth of the wiki and makes use of the rarer used "startpage named like the namespace" method for start pages. The existing code has not been modified, yet and continues to use the old, now deprecated methods. Some tests are still failing - before they are fixed, the expected behaviour needs to be discussed.
splitbrain
force-pushed
the
refactorResolving
branch
from
1356e56
to
bfcf800
Compare
|
Things I'd like to discuss:
|
This was copy'n'pasted from resolve_pageid. To correctly handle the date_at parameter a media_exists() function had to be introduced.
Replaces the use of resolve_pageid() and resolve_mediaid() with the proper class invocations
* master: (257 commits) add unit test for namespace exclusion in ft_pageLookup() exclude ns in pagelook ups translation update Obsolete attribute translation update translation update translation update translation update translation update Add missing `;` causing syntax error in js.php Run tests on PHP 8.0 now translation update translation update test: run test in separate process in case of error test: fix two tests on PHP8 style: fix test code style fix method handling for RPC_CALL_ADD destroy the JPEGMeta object after use upgrade simplepie to 1.5.6 dwpage: output meta data as JSON ...
* master: (37 commits) disable jit compiling to avoid broken pcre lib #3507 Remove phpunit cache. Fix PHPUnit fatal errors compatibility with void. Method names with leading double underscore are reserved by PHP. fix named access to the sha hashing mechanisms adjust help text of extension cli move IXR XML RPC to composer dependency #1970 translation update 🔥 fix the calculation of file permissons Do not duplicate the foreach ($installed... translation update Allow installing extenions from URL via the CLI Add support for SHA256 encrypted passwords plugins/extension: Fix git recognition for plugin installations via git-submodules. HTTPClient: Fix missing processing of redirections with status code 303, 307, 308. SVG for interwiki links translation update manifest: add NOSESSION to not require auth add missing google interwiki link. fixes #3502 translation update ...
This dosn't really change the behaviour but makes the code easier to grasp. A simple unit test has been added.
When an empty link was given, the old implementation fell back to $ID, this was handled incorrectly in the deprecated method.
This comment has been minimized.
This comment has been minimized.
See #3272 (comment) for reasoning
|
Do you think PR can be combined with #3079? Seems like there's some overlap in regards to intent. |
Klap-in
reviewed
Dec 27, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
* master: (142 commits) authPDO: extend mysql test to ensure multiple groups are read update DokuWiki install URL update smtp plugin URL update flashplayer URL Revert "Merge pull request #3039 from takuy/video-attributes" Revert "fixed video attribute handling in php8" Revert "more php8 fixes for the video attributes" guard against unsert user name. fixes #3455 remove remaining X-UA-Compatible headers. fixes #3434 more php8 fixes for the video attributes fixed video attribute handling in php8 fix test for draft file fix security problems in draft handling. fixes #3565 fix handling of loading auth backend check CSRF token in draftdel action. fixes #3563 ignore another PSR12 style check for now authplain: properly clean user names Removes use of deprecated create_function() in teests. Replaces them with anonymous functions. Refs #3545 check security token on logout. fixes #3561 create SECURITY.md fixes #3558 ...
|
I moved the classes into the |
|
@splitbrain, If using [[~example]] on foo:bar, then you will see in the text |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
resolve_id()type of functions into their own class hierarchy.A new shortcut to be used in links is introduced. The tilde
~can be used to reference the current page as a namespace. This is useful to dynamically create a new namespace from an existing page, effectively making that page the start page. It allows for a more dynamic growth of the wiki and makes use of the rarer used "startpage named like the namespace" method for start pages.The existing code has not been modified, yet and continues to use the old, now deprecated methods. Some tests are still failing - before they are fixed, the expected behaviour needs to be discussed.